ICS07: Add verification method for client update handler #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…formalsystems/ibc-rs into Check-Header-And-Update-State
…formalsystems/ibc-rs into Check-Header-And-Update-State
Signed-off-by: Thane Thomson <[email protected]>
ancazamfir
reviewed
Oct 6, 2021
ancazamfir
reviewed
Oct 6, 2021
…rait Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
ancazamfir
approved these changes
Oct 12, 2021
romac
requested changes
Oct 12, 2021
romac
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
LGTM, thank you so much for all the work, @cezarad @thanethomson and @ancazamfir!
adizere
approved these changes
Oct 14, 2021
adizere
reviewed
Oct 14, 2021
| use crate::timestamp::ZERO_DURATION; | ||
| use std::ops::Add; |
There was a problem hiding this comment.
One last concern: should we scrub this PR for std ?
There was a problem hiding this comment.
It's in tests, which we will run with std, so it doesn't really matter whether we import from std or core, but in this case it wouldn't hurt to just import from core for consistency.
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…tems#1321) * bla * on going * ongoing * on going * on going * timestamp default changed from none to now * failed ping pong - signs * Update context.rs * bla * blabla * fixed test client_update_ping_pong * fmt + clippy * Update context.rs * Update context.rs * remove comments * Update host.rs * Update to tendermint-rs v0.20.0 * Update changelog * Fix tendermint-rs version in changelog * Update predicates.rs * Update context.rs * tests * tendermint stuff in * Update Cargo.toml * clippy + fmt * moved predicates into ics07 header.rs * Adapted to latest TM changes * Fixed MockHeader test * Fmt & clippy * Removed irrelevant file * Bit more cleanup * fixed tests * upgraded to new error model * fmt * errors and timestamp changes * Fix error notation and formatting Signed-off-by: Thane Thomson <[email protected]> * Upgrade to tendermint-rs master Signed-off-by: Thane Thomson <[email protected]> * Use tendermint-rs from branch thane/ibc-1252 Signed-off-by: Thane Thomson <[email protected]> * Refactor ICS07 update handler to reuse light client verifier This commit makes use of the latest code from informalsystems/tendermint-rs#960 in order to reuse the light client's verification predicates instead of reimplementing them in the `ibc` crate. Signed-off-by: Thane Thomson <[email protected]> * Update Cargo.lock to address zeroize issue Signed-off-by: Thane Thomson <[email protected]> * Bump tendermint-light-client dep to v0.22.0 for ibc module Signed-off-by: Thane Thomson <[email protected]> * Refactor to accommodate new context API Signed-off-by: Thane Thomson <[email protected]> * Fix missing import Signed-off-by: Thane Thomson <[email protected]> * Fix imports Signed-off-by: Thane Thomson <[email protected]> * Fix error check in test Signed-off-by: Thane Thomson <[email protected]> * Output debug version of error Signed-off-by: Thane Thomson <[email protected]> * Remove test as per informalsystems#1321 (comment) Signed-off-by: Thane Thomson <[email protected]> * Address comments from Adi Signed-off-by: Thane Thomson <[email protected]> * Cosmetic tweaks Signed-off-by: Thane Thomson <[email protected]> * Add revision number check Signed-off-by: Thane Thomson <[email protected]> * Fix broken test Signed-off-by: Thane Thomson <[email protected]> * Check incoming header height against chain ID version from client state Signed-off-by: Thane Thomson <[email protected]> * Add revision_number consistency check when deserializing header Signed-off-by: Thane Thomson <[email protected]> * Clarify MismatchedRevisions error message Signed-off-by: Thane Thomson <[email protected]> * Add changelog entries Signed-off-by: Thane Thomson <[email protected]> * Commented import no longer necessary Signed-off-by: Thane Thomson <[email protected]> * Add in-the-middle monotonicity checks Signed-off-by: Thane Thomson <[email protected]> * Fix broken dep tree relating to Prometheus Signed-off-by: Thane Thomson <[email protected]> * Move next/prev consensus state search functionality to ClientReader trait Signed-off-by: Thane Thomson <[email protected]> * Move impl of prev/next to the specific implementation and simplify signatures * Disable `tendermint-light-client` default features, ie. RPC client, std and color-eyre * Apply suggestions from code review * Fix compilation * Cleanup BTreeMap import * Always show underlying reason in ics07_tendermint errors * Update modules/src/ics02_client/handler/update_client.rs * Fix compilation Co-authored-by: cezarad <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> Co-authored-by: cezarad <[email protected]> Co-authored-by: Adi Seredinschi <[email protected]> Co-authored-by: Anca Zamfir <[email protected]>
hu55a1n1
pushed a commit
to cosmos/ibc-rs
that referenced
this pull request
Sep 29, 2022
* bla * on going * ongoing * on going * on going * timestamp default changed from none to now * failed ping pong - signs * Update context.rs * bla * blabla * fixed test client_update_ping_pong * fmt + clippy * Update context.rs * Update context.rs * remove comments * Update host.rs * Update to tendermint-rs v0.20.0 * Update changelog * Fix tendermint-rs version in changelog * Update predicates.rs * Update context.rs * tests * tendermint stuff in * Update Cargo.toml * clippy + fmt * moved predicates into ics07 header.rs * Adapted to latest TM changes * Fixed MockHeader test * Fmt & clippy * Removed irrelevant file * Bit more cleanup * fixed tests * upgraded to new error model * fmt * errors and timestamp changes * Fix error notation and formatting Signed-off-by: Thane Thomson <[email protected]> * Upgrade to tendermint-rs master Signed-off-by: Thane Thomson <[email protected]> * Use tendermint-rs from branch thane/ibc-1252 Signed-off-by: Thane Thomson <[email protected]> * Refactor ICS07 update handler to reuse light client verifier This commit makes use of the latest code from informalsystems/tendermint-rs#960 in order to reuse the light client's verification predicates instead of reimplementing them in the `ibc` crate. Signed-off-by: Thane Thomson <[email protected]> * Update Cargo.lock to address zeroize issue Signed-off-by: Thane Thomson <[email protected]> * Bump tendermint-light-client dep to v0.22.0 for ibc module Signed-off-by: Thane Thomson <[email protected]> * Refactor to accommodate new context API Signed-off-by: Thane Thomson <[email protected]> * Fix missing import Signed-off-by: Thane Thomson <[email protected]> * Fix imports Signed-off-by: Thane Thomson <[email protected]> * Fix error check in test Signed-off-by: Thane Thomson <[email protected]> * Output debug version of error Signed-off-by: Thane Thomson <[email protected]> * Remove test as per informalsystems/hermes#1321 (comment) Signed-off-by: Thane Thomson <[email protected]> * Address comments from Adi Signed-off-by: Thane Thomson <[email protected]> * Cosmetic tweaks Signed-off-by: Thane Thomson <[email protected]> * Add revision number check Signed-off-by: Thane Thomson <[email protected]> * Fix broken test Signed-off-by: Thane Thomson <[email protected]> * Check incoming header height against chain ID version from client state Signed-off-by: Thane Thomson <[email protected]> * Add revision_number consistency check when deserializing header Signed-off-by: Thane Thomson <[email protected]> * Clarify MismatchedRevisions error message Signed-off-by: Thane Thomson <[email protected]> * Add changelog entries Signed-off-by: Thane Thomson <[email protected]> * Commented import no longer necessary Signed-off-by: Thane Thomson <[email protected]> * Add in-the-middle monotonicity checks Signed-off-by: Thane Thomson <[email protected]> * Fix broken dep tree relating to Prometheus Signed-off-by: Thane Thomson <[email protected]> * Move next/prev consensus state search functionality to ClientReader trait Signed-off-by: Thane Thomson <[email protected]> * Move impl of prev/next to the specific implementation and simplify signatures * Disable `tendermint-light-client` default features, ie. RPC client, std and color-eyre * Apply suggestions from code review * Fix compilation * Cleanup BTreeMap import * Always show underlying reason in ics07_tendermint errors * Update modules/src/ics02_client/handler/update_client.rs * Fix compilation Co-authored-by: cezarad <[email protected]> Co-authored-by: Romain Ruetschi <[email protected]> Co-authored-by: cezarad <[email protected]> Co-authored-by: Adi Seredinschi <[email protected]> Co-authored-by: Anca Zamfir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes cosmos/ibc-rs#71
Builds on and replaces #1252 with the following changes:
tendermint-light-clientcrate in implementing ICS07.flex-errorintegration.For contributor use:
unclog.docs/) and code comments.Files changedin the Github PR explorer.